Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use common base class for legacy and modern reader, move logic from nd2file #160

Merged
merged 10 commits into from
Jul 9, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Jul 9, 2023

big internal refactor to cleanup and unify the protocol that legacy and modern readers use.

This also has legacy readers return a proper Metadata object

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #160 (cba6f9b) into main (a86bb6d) will increase coverage by 0.22%.
The diff coverage is 91.42%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   93.66%   93.88%   +0.22%     
==========================================
  Files          16       17       +1     
  Lines        2272     2340      +68     
==========================================
+ Hits         2128     2197      +69     
+ Misses        144      143       -1     
Impacted Files Coverage Δ
src/nd2/_binary.py 88.57% <ø> (-2.44%) ⬇️
src/nd2/_parse/_chunk_decode.py 87.40% <ø> (ø)
src/nd2/_parse/_clx_lite.py 91.50% <ø> (ø)
src/nd2/_parse/_clx_xml.py 89.36% <ø> (ø)
src/nd2/_parse/_legacy_xml.py 97.50% <ø> (ø)
src/nd2/_sdk_types.py 100.00% <ø> (ø)
src/nd2/index.py 97.58% <ø> (ø)
src/nd2/readers/protocol.py 90.14% <90.14%> (ø)
src/nd2/readers/_legacy/legacy_reader.py 90.34% <90.34%> (ø)
src/nd2/readers/_modern/modern_reader.py 92.02% <92.30%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 9, 2023

CodSpeed Performance Report

Merging #160 will not alter performances

Comparing reader-base (cba6f9b) with main (a86bb6d)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 enabled auto-merge (squash) July 9, 2023 15:07
@tlambert03 tlambert03 merged commit 4ea166e into main Jul 9, 2023
15 of 16 checks passed
@tlambert03 tlambert03 deleted the reader-base branch July 9, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant