Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix binary reshaping #164

Merged
merged 1 commit into from
Jul 15, 2023
Merged

fix: fix binary reshaping #164

merged 1 commit into from
Jul 15, 2023

Conversation

tlambert03
Copy link
Owner

Fixes a bug where binary layers were not being reshaped properly

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #164 (bdd148c) into main (1dff890) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   95.04%   95.04%   -0.01%     
==========================================
  Files          17       17              
  Lines        2323     2322       -1     
==========================================
- Hits         2208     2207       -1     
  Misses        115      115              
Impacted Files Coverage Δ
src/nd2/_sdk_types.py 100.00% <ø> (ø)
src/nd2/_binary.py 89.70% <100.00%> (ø)
src/nd2/readers/_modern/modern_reader.py 92.85% <100.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 enabled auto-merge (squash) July 15, 2023 19:28
@tlambert03 tlambert03 merged commit bdbc82c into main Jul 15, 2023
16 checks passed
@tlambert03 tlambert03 deleted the fix-binary branch July 15, 2023 19:28
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2023

CodSpeed Performance Report

Merging #164 will not alter performance

Comparing fix-binary (bdd148c) with main (1dff890)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 added the bug Something isn't working label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant