Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Z series values in events() output, and add individual axis indices #167

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

tlambert03
Copy link
Owner

Fixes the values for Z Series in events() and also adds T index, C Index, Z Index, etc...

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 31, 2023

CodSpeed Performance Report

Merging #167 will degrade performances by 14.18%

Comparing fix--fix-events-z-index (5666064) with main (a70c051)

Summary

❌ 1 (👁 1) regressions
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main fix--fix-events-z-index Change
👁 test_time_all_metadata[jonas_control002] 34.1 ms 39.7 ms -14.18%

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #167 (5666064) into main (a70c051) will increase coverage by 0.05%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   95.04%   95.10%   +0.05%     
==========================================
  Files          17       17              
  Lines        2322     2327       +5     
==========================================
+ Hits         2207     2213       +6     
+ Misses        115      114       -1     
Files Changed Coverage Δ
src/nd2/_ome.py 97.61% <ø> (-0.11%) ⬇️
src/nd2/readers/_modern/modern_reader.py 93.28% <95.00%> (+0.43%) ⬆️
src/nd2/_parse/_parse.py 93.81% <100.00%> (+0.04%) ⬆️
src/nd2/_util.py 97.26% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 merged commit f9feb42 into main Aug 31, 2023
18 checks passed
@tlambert03 tlambert03 deleted the fix--fix-events-z-index branch August 31, 2023 17:31
@tlambert03 tlambert03 added bug Something isn't working enhancement New feature or request labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant