fix: Fix images where widthPx x Bytes is not the same as expected width Bytes #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #88 (which was also showing in a couple datasets).
Occasionally,
attributes.widthPx
will not be the same asattributes.widthBytes // (attributes.componentCount * attributes.bitsPerComponentInMemory // 8)
, as was the case with @aaristov's dataset in #88.In those cases both the sdk reader and the native memmap reader result in skewed images (see #88). Oddly enough, the NIS elements viewer is fine with these files, suggesting they don't directly use the SDK reader internally :/
This PR catches those cases, emits a warning, and forces the image width in pixels to be
widthBytes // (componentCount * bitsPerComponentInMemory // 8)