Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FiniteSetsExt!Sum and FiniteSetsExt!Product easily name-clash #62

Closed
lemmy opened this issue Jan 14, 2022 · 1 comment
Closed

FiniteSetsExt!Sum and FiniteSetsExt!Product easily name-clash #62

lemmy opened this issue Jan 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@lemmy
Copy link
Member

lemmy commented Jan 14, 2022

CommunityModules/modules/FiniteSetsExt.tla

Lines 16 to 32 in 23fbb1f

Sum(set) ==
(*************************************************************************)
(* Calculate the sum of the elements in set. *)
(* *)
(* Example: *)
(* Sum(0 .. 10) = 55 *)
(*************************************************************************)
FoldSet(+, 0, set)
Product(set) ==
(*************************************************************************)
(* Calculuate the product of the elements in set. *)
(* *)
(* Example: *)
(* Product(1 .. 3) = 6 *)
(*************************************************************************)
FoldSet(LAMBDA x, y: x * y, 1, set)

Sum -> SumSet
Product -> ProductSet

Both names would also be in line with ReduceSet.

Objections anybody?
@lemmy lemmy added the enhancement New feature or request label Jan 14, 2022
@muenchnerkindl
Copy link
Contributor

Sounds good to me.

lemmy added a commit that referenced this issue Jan 14, 2022
@lemmy
Avoid name clashes with Sum and Product.
677d3d4 
Fixes Github issue #62
#62

[Refactor]
@lemmy lemmy closed this as completed Jan 14, 2022
lemmy added a commit that referenced this issue Apr 10, 2022
@lemmy
Avoid name clashes with Sum and Product.
c66dc93 
Fixes Github issue #62
    #62

[Refactor]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemmy @muenchnerkindl