Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "alygin.vscode-tlaplus" and "alygin.vscode-tlaplus-nightly" on VSCode Marketplace with TLA+ Foundation owned publisher #318

Closed
lemmy opened this issue Dec 19, 2023 · 19 comments
Labels
enhancement New feature or request

Comments

@lemmy
Copy link
Member

lemmy commented Dec 19, 2023

We've decided to deprecate alygin.vscode-tlaplus and alygin.vscode-tlaplus-nightly in favor of the TLA+ Foundation controlled tlaplus.vscode-ide.

The released version of this extension, found at alygin.vscode-tlaplus, is severely outdated (last update was in 2021). I suggest to replace the released version with the "nightly build" version, available at alygin.vscode-tlaplus-nightly. In other words, I propose to discontinue the "released" version of the extension and instead, updating the main "alygin.vscode-tlaplus" extension with the content from "alygin.vscode-tlaplus-nightly". This will ensure that users have access to the most recent version of the extension. It also addresses the issue that users can install both the "released" and "nightly" versions concurrently, and run into issues due to conflicts between the two versions. By merging them into one, this problem would be resolved.

Thoughts? @kape1395 @afonsonf @alygin @klinvill @ALL...

@lemmy lemmy added the enhancement New feature or request label Dec 19, 2023
@kape1395

This comment was marked as outdated.

@lemmy

This comment was marked as outdated.

@lemmy

This comment was marked as outdated.

lemmy added a commit that referenced this issue Aug 8, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 8, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 15, 2024
…Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 16, 2024
with "tlaplus-lang.vscode-tlaplus" on Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 16, 2024
with "tlaplus-lang.tlaplus-lang" on Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 16, 2024
with "tlaplus-lang.tlaplus-lang" on Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 16, 2024
with "tlaplus-lang.tlaplus-lang" on Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Aug 16, 2024
with "tlaplus-lang.tlaplus-lang" on Marketplace.

Part of Github issue #318
#318

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
@lemmy
Copy link
Member Author

lemmy commented Aug 16, 2024

I've created a new VSCode marketplace publisher that's "owned" by the TLA+ Foundation: https://marketplace.visualstudio.com/items?itemName=tlaplus.vscode-ide

@kape1395 @FedericoPonzi Please share your Microsoft account to be added as owners of the marketplace publisher.

@lemmy lemmy changed the title Merge "alygin.vscode-tlaplus" and "alygin.vscode-tlaplus-nightly" on Marketplace Replace "alygin.vscode-tlaplus" and "alygin.vscode-tlaplus-nightly" on VSCode Marketplace with TLA+ Foundation owned publisher Aug 16, 2024
@kape1395
Copy link
Collaborator

@lemmy, my account Karolis Petrauskas (k.petrauskas@gmail.com) User Id : 336ed76d-ac43-6c31-9b7e-079e407795b1

@kape1395

This comment was marked as resolved.

@lemmy
Copy link
Member Author

lemmy commented Aug 21, 2024

@lemmy, my account Karolis Petrauskas (k.petrauskas@gmail.com) User Id : 336ed76d-ac43-6c31-9b7e-079e407795b1

You have been added as an owner of the extension at https://marketplace.visualstudio.com/manage/publishers/tlaplus. You and I are able to add additional users.

@lemmy

This comment was marked as resolved.

@lemmy
Copy link
Member Author

lemmy commented Aug 21, 2024

@afonsonf What's your vscode marketplace id?

@afonsonf
Copy link
Collaborator

@afonsonf What's your vscode marketplace id?

Hi, my id is 35e6c390-a822-6fb6-8871-861e28fbe73f

@lemmy
Copy link
Member Author

lemmy commented Aug 27, 2024

Old extensions have been deprecated:

Screenshot 2024-08-27 at 2 40 28 PM

@filiptronicek
Copy link

Hi @lemmy, would it, as a part of this change, be possible to publish the extension under the new namespace under https://open-vsx.org/ as well? For context, I'm trying to also mark the extension as deprecated on Open VSX, but the replacement, tlaplus.vscode-ide is not yet available.

lemmy added a commit that referenced this issue Sep 19, 2024
(old extension had >50k downloads)

Par of Github issue #318
#318 (comment)

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy added a commit that referenced this issue Sep 19, 2024
(old extension had >50k downloads)

Par of Github issue #318
#318 (comment)

[Build]

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
@lemmy
Copy link
Member Author

lemmy commented Sep 19, 2024

Done: https://open-vsx.org/extension/tlaplus/vscode-ide

@filiptronicek
Copy link

Thanks for the superfast turnaround!

@lemmy
Copy link
Member Author

lemmy commented Oct 4, 2024

@filiptronicek Would you happen to know what breaks our OVSX publishing: https://github.com/tlaplus/vscode-tlaplus/actions/runs/11185435522/job/31098301346 ?

@filiptronicek
Copy link

@lemmy it looks like you're trying to override version 1.7.0. If you bump the version in your package.json, publishing should work.

@lemmy
Copy link
Member Author

lemmy commented Oct 4, 2024

I see, we don't have to do that with the VSCode marketplace because vsce publish accepts a version number:

vsce publish $(git log -1 --format=%cd --date="format:%Y.%-m.%-d%H%M") --pat "${{ secrets.VSCODE_MARKETPLACE_TLAPLUS_TOKEN }}"

Is there a reason why ovsx publish doesn't accept a version number?

@filiptronicek
Copy link

filiptronicek commented Oct 5, 2024

@lemmy interesting find, ovsx has a positional argument too, but it accepts a .vsix pathname instead of a version. Given the fact that ovsx is a wrapper around an internal vsce, there are some differences in arguments and flags. Feel free to raise an issue in https://github.com/eclipse/openvsx if you have suggestions regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants