Module search paths can be shared between tools. #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
lemmy
reviewed
Feb 4, 2024
| @@ -25,10 +25,12 @@ const NO_ERROR = 0; | |||
| const MIN_TLA_ERROR = 10; // Exit codes not related to tooling start from this number | |||
| const LOWEST_JAVA_VERSION = 8; | |||
| const DEFAULT_GC_OPTION = '-XX:+UseParallelGC'; | |||
| const TLA_CMODS_LIB_NAME = 'CommunityModules-deps.jar'; | |||
There was a problem hiding this comment.
TLC automatically side-loads CommunityModules-deps.jar if present.
There was a problem hiding this comment.
I see. This works for Java if I understand correctly, but for the TLAPS to use modules from both jars, I have to provide them both as module search paths.
By the way, I added support for using modules from zips/jars in TLAPM.
lemmy
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to resolve #323
The paths are passed to SANY and TLC. TLAPS gets the paths as well.
For visibility, I added a tree view to see the paths and their origins.
jar:paths are ignored for now but should be supported later.