Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file path parsing in sany output #330

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

afonsonf
Copy link
Collaborator

Changes

  • Fixes file path parsing in sany output
    • In windows line is as follows: Parsing file C:\Users\Afonso\CPlusCal.tla (file:/c:/Users/Afonso/CPlusCal.tla)
    • In Linux line is as follows: Parsing file /workspaces/folder/CPlusCal.tla
    • Custom sany parser expects line to end with (jar:file:.*) or nothing, changed to expect (.*) or nothing
  • In case filepath or changes range are null show action name instead of null
  • Remove files property from package json as that information is present in .vscodeignore file and having both causes vsce to not work with following error
    • ERROR Both a .vscodeignore file and a "files" property in package.json were found. VSCE does not support combining both strategies. Either remove the .vscodeignore file or the "files" property in package.json.

Fixes #329

Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
@afonsonf afonsonf force-pushed the fix-329-sany-parsing branch from c497f6e to 11aab45 Compare August 27, 2024 20:56
src/parsers/sany.ts Outdated Show resolved Hide resolved
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
@afonsonf
Copy link
Collaborator Author

Can you merge the PR @lemmy ? Thanks

@lemmy lemmy merged commit 22c3497 into tlaplus:master Aug 29, 2024
4 checks passed
@lemmy
Copy link
Member

lemmy commented Aug 29, 2024

Done.

I assumed that you have the necessary permissions. Will correct asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Coverage has blank Action on both Nightly and TLA+ Foundation's TLA+ VScode, Alygin's version is OK.
2 participants