Display infobox when .cfg is missing #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoPonzi
force-pushed
the
issue-331
branch
from
3735696 to
4f3e81a
Compare
When running command "TLA+: Check model with TLC", if the .cfg file is missing, we don't get a warning or anything. This can be source of confusion. Removed the warn parameter as it was already defaulting to true. This will lead in more consistent behavior as well. Signed-off-by: Federico Ponzi <me@fponzi.me>
FedericoPonzi
force-pushed
the
issue-331
branch
from
4f3e81a to
2543913
Compare
|
Given a model |
lemmy
approved these changes
Sep 27, 2024
|
I get the two popup boxes now on every editor save when editing auxiliary modules, i.e. not the root module. |
FedericoPonzi
added a commit
to FedericoPonzi/vscode-tlaplus
that referenced
this pull request
Oct 4, 2024
FedericoPonzi
added a commit
to FedericoPonzi/vscode-tlaplus
that referenced
this pull request
Oct 4, 2024
Do you have specific hooks on save? I tried and failed to reproduce it. Also, the code path seems to be triggered only from check, debug or evaluate expression commands; so I'm not sure how they are showing up on save. |
|
|
Can you also include the settings you've added? |
"tlaplus.smoke.prefix.path": "../.smoke/",
"tlaplus.smoke.prefix.name": "Smoke",
"[tlaplus]": {
"editor.codeActionsOnSave": {
"source": "explicit"
}
}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running command "TLA+: Check model with TLC", if the .cfg file is missing, we don't get a warning or anything. This can be
source of confusion. Removed the warn parameter as it was already defaulting to true. This will lead in more consistent behavior as well.
Solves: #331
Ref: #335 and commit: 2092aeb
New behavior when running "TLA+: Check model with TLC":
