Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Generation: feature parity with the toolbox #349

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

FedericoPonzi
Copy link
Collaborator

@FedericoPonzi FedericoPonzi commented Oct 31, 2024

Fixes #348.
Adds few options to the plugin, lifted from https://github.com/tlaplus/tlaplus/blob/ab14a33e39c78e4c88e81b664b9a8c916b943cab/toolbox/org.lamport.tla.toolbox.tool.tla2tex/src/org/lamport/tla/toolbox/tool/tla2tex/handler/ProducePDFHandler.java#L106:

image

This is with comment shade option checked:
image

With shade of 0.2:
image

With the numbered option:
image

With no pcal shade unchecked:
image

With nopcal shade checked:
image

@FedericoPonzi FedericoPonzi force-pushed the issue-348 branch 2 times, most recently from f8ae898 to c9d2e3b Compare October 31, 2024 21:37
@FedericoPonzi FedericoPonzi requested a review from lemmy October 31, 2024 21:49
@FedericoPonzi FedericoPonzi force-pushed the issue-348 branch 2 times, most recently from 71c87dd to 63fa1cf Compare October 31, 2024 22:21
@FedericoPonzi FedericoPonzi marked this pull request as ready for review October 31, 2024 22:52
@FedericoPonzi FedericoPonzi force-pushed the issue-348 branch 2 times, most recently from f7b181d to daa4645 Compare October 31, 2024 22:56
src/tla2tools.ts Show resolved Hide resolved
src/tla2tools.ts Outdated Show resolved Hide resolved
Signed-off-by: Federico Ponzi <me@fponzi.me>
@FedericoPonzi FedericoPonzi merged commit 3c89285 into tlaplus:master Nov 1, 2024
4 checks passed
@FedericoPonzi FedericoPonzi deleted the issue-348 branch November 1, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Generating PDF does not gray shade comments
2 participants