Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lint check for lowercase filename #42

Merged
merged 2 commits into from
Feb 8, 2021
Merged

feat: add lint check for lowercase filename #42

merged 2 commits into from
Feb 8, 2021

Conversation

owenvoke
Copy link
Member

With this change, the following pages are showing as needing to be changed (in the main English versions):

pages/common/R.md:0: TLDR109 File name should be lowercase
pages/common/theHarvester.md:0: TLDR109 File name should be lowercase
pages/linux/eyeD3.md:0: TLDR109 File name should be lowercase
pages/osx/GetFileInfo.md:0: TLDR109 File name should be lowercase
pages/osx/csshX.md:0: TLDR109 File name should be lowercase

Closes tldr-pages/tldr#5085 (kind of...)

MasterOdin
MasterOdin approved these changes Feb 1, 2021
View reviewed changes
lib/tldr-lint.js Outdated Show resolved Hide resolved
@owenvoke @MasterOdin
style: use regex literal
6286357 
Co-authored-by: Matthew Peveler <matt.peveler@gmail.com>
@schneiderl
Copy link
Contributor

Shall we merge this? Or should we change the pages before?

@bl-ue
Copy link
Contributor

bl-ue commented Feb 6, 2021

Oh, we should probably fix the erroring pages first.

@schneiderl
Copy link
Contributor

@bl-ue off-topic question: don't you sleep? whenever I post a comment I'm sure I'll have a response from you within 10 minutes haha

@bl-ue
Copy link
Contributor

bl-ue commented Feb 6, 2021 •
edited
Loading

😄 Haha yeah I'm UTC-0500 :)

Don't worry though, it won't be that way forever :D

Glad I'm making a big impression though! Hope I'm not too bothersome...

@MasterOdin
Copy link
Contributor

Shall we merge this? Or should we change the pages before?

Merging this before fixing any page is fine as it will not apply to the tldr-pages/tldr repo until a new version of the tldr-lint is made and the version bumped in the former's package.json.

@schneiderl
Copy link
Contributor

Hope I'm not too bothersome...

Not at all! It is very nice to have those quick replies.

@schneiderl schneiderl mentioned this pull request Feb 8, 2021
Closed
@schneiderl schneiderl merged commit e725b61 into tldr-pages:main Feb 8, 2021
@schneiderl schneiderl mentioned this pull request Feb 8, 2021
Closed
@owenvoke owenvoke deleted the feature/lowercase-filenames branch February 8, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@schneiderl schneiderl schneiderl approved these changes

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to handle mixed casing of titles and filenames
4 participants
@owenvoke @schneiderl @bl-ue @MasterOdin