Tidy up tests #294
Tidy up tests #294
Conversation
* Add nyc coverage tool * Remove `env-test`: it's a single line for the cost of a module * Set NODE_ENV in custom set up file * Stub console for each test individually globally * Plus: a `sinon.restore()` in global afterEach prevents cross test leaks * Add most basic test for `Tldr` class, just to trigger coverage * Remove surplus mocha args: * It always looks in test dir * `mocha.opts` provides a more consistent approach * Ignore coverage files now created by nyc
| @@ -0,0 +1,11 @@ | |||
| process.env.NODE_ENV = 'test'; | |||
There was a problem hiding this comment.
Move this to mocha.opts as --env flag cause that is where people would typically look for it. Add use strict pragma on the top of the file.
There was a problem hiding this comment.
Could you give me the syntax of a --env flag with mocha? I'm looking for it's documentation and have thrown some stuff at the wall, but nothing seems to work.
There was a problem hiding this comment.
I don't think there is an --env flag: mochajs/mocha#185. I am good with this or setting it via a variable in the npm invocation string.
test/mocha.opts
Outdated
| @@ -1,3 +1,3 @@ | |||
| --reporter spec | |||
There was a problem hiding this comment.
While we are here, can we move from mocha.opts to a config file ? Looks like it is deprecated and will be removed in future: https://mochajs.org/#mochaopts. .mocharc.js looks fine by me.
| @@ -0,0 +1,11 @@ | |||
| process.env.NODE_ENV = 'test'; | |||
There was a problem hiding this comment.
I don't think there is an --env flag: mochajs/mocha#185. I am good with this or setting it via a variable in the npm invocation string.
Description
env-test: it's a single line for the cost of a modulesinon.restore()in global afterEach prevents cross test leaksTldrclass, just to trigger coverage* It always looks in test dir
*
mocha.optsprovides a more consistent approachChecklist
Please review this checklist before submitting a pull request.
npm run test:all)