-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openbsd: add directory; openbsd/pkg_{add,info,delete}: add page #10698
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I have started a discussion in our chatroom regarding the new directory addition, let's hope we reach a consensus on it soon.
I have a few suggestions now. I will add a general pkg
page which refers to these subpages.
Hi, I have taken over this PR and performed the changes as specified in the maintainer's guide; Thanks for your initial work. For those who haven't checked the chatroom, other maintainers approved having a new openbsd directory for its unique platform-specific commands and packages. So there aren't any blockers in this PR anymore and it can be merged after reviewing the page's contents. Post this PRs merge, I will update the Client specification to add support for this directory. |
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
Just now went through the client specification, I don't think we need to add any additional information about the change as https://github.com/tldr-pages/tldr/blob/main/CLIENT-SPECIFICATION.md#platform and https://github.com/tldr-pages/tldr/blob/main/CLIENT-SPECIFICATION.md#directory-structure are already written in a generalized manner. |
Clients still have to be updated though. |
Yeah. In the next client specification release, we can mention the new platform addition in the meanwhile we can focus on documenting its pages (maybe with a Let's document issue). Btw, what do you think we should version the next release of client specification? (the last one was 2.0 since it introduced a major change). I will create a milestone and add your PR and this one to it. |
There's an ongoing client spec PR (#10730) so maybe we can add it there (and bump the version too). Also, if we are going to add all the BSD platforms, it would be great to add all of them ( |
Yep that's exactly what I am inquiring about, what version number should we choose for the future release so that we can create a milestone (here on this repo) to track all things related to it before creating a release. |
I think we are only going to add |
Do we consider the placeholder escaping syntax a breaking change? If so, I guess it should be
A package manager, that's for sure. There's even an issue to document it. Other than that, I don't know, I've never used NetBSD. |
IMO it isn't a breaking change so we can go with a minor version
We could document it if there are multiple commands, if not then we can include them under openbsd itself but mention it is for NetBSD. |
common
,linux
,osx
,windows
,sunos
,android
, etc.As mentioned here I'm creating what seem to be the first few tldrs for OpenBSD, that include
pkg_add
,pkg_info
andpkg_delete
.Closes #816