-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set: add page #2294
set: add page #2294
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
Is this the only example common across all shells ? |
@agnivade no, there are more but I did not check across all available shells. |
Since it is in common, windows support is must. So I would say powershell, bash, zsh are essential. |
@agnivade if we have to include |
You can also split the page into 2. Put one inside windows/ and the other with more options in common/. Windows clients will automatically take the more specific page. |
@agnivade I think this is a very good idea. Let me split them up into two pages :) |
@agnivade It turns out that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just taken another look got a few more comments for you to review:
pages/common/set.md
Outdated
|
||
- Set various options, e.g. enable `vi` style line editing: | ||
|
||
`set -o vi` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps vi
should be surrounded by {{
and }}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh... yes :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me - thanks @mfrw 😺
Closes #2268
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being edited.The page follows the contributing guidelines.