Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chinese punctuation in Chinese pages #2897

Closed
wants to merge 3 commits into from

Conversation

telnetning
Copy link

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@sbrl
Copy link
Member

sbrl commented Apr 11, 2019

Hey, @telnetning! I'm unsure what this PR does. Could you explain please? The PR title doesn't explain it very well.

@schneiderl
Copy link
Collaborator

This PR seems to be adjusting the punctuation marks to the Chinese set of punctuation marks as it makes no sense to use European punctuation on texts written in Chinese. More information about that can be found here.

Am I right @telnetning ?
In my opinion this PR changes do make a lot of sense.

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @telnetning, thanks for your contribution. While I understand the reason of this PR, I would advise not changing punctuation inside commands, since that does not make much sense: commands (and especially URLs) rely on those exact ASCII symbols, and cannot work using different symbols even if they have the same grammatical meaning.

You should change the following instances back to their original form.

pages.zh/linux/apt-key.md Outdated Show resolved Hide resolved
pages.zh/linux/arp-scan.md Outdated Show resolved Hide resolved
@mebeim mebeim added the page edit Changes to an existing page(s). label Apr 11, 2019
@mebeim mebeim changed the title Telnetning Use Chinese punctuation in Chinese pages Apr 11, 2019
@telnetning
Copy link
Author

@sbrl @schneiderl yes, schneiderl is right.
And thanks @mebeim , the punctuation inside commands really shouldn't be changed.

I make this change according to Guides For Free Software Localization Working(自由软件中文化工作指南, sorry for it's only available in chinese).

This document suggests that the punctuations(except .../--/()) should be translated into Chinese on texts.

mebeim
mebeim previously approved these changes Apr 12, 2019
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think it is clear enough that this is the correct way to go. I did not know about Chinese punctuation being different from English, but I took a look at different pages online after reading this and realized that it is indeed to be preferred. Thank you again @telnetning. We'll probably squash these 3 commits into one since the last two are just fixes.

@mebeim mebeim dismissed their stale review April 12, 2019 10:00

Rushed approval.

@mebeim
Copy link
Member

mebeim commented Apr 12, 2019

On second thought I would like to hear some other opinions before actually deciding whether this should be merged or not. Excuse my rushed approval, but since such changes would obviously mess with the current page formatting rules, and possibly the clients, it should be discussed.

This would basically break the current page format rules. I don't necessarily see that as a problem, but we need to consider whether it is actually appropriate to do this for the sake of correctness or not. After all we're talking about almost identical punctuation marks, but obviously very different in terms of the actual characters used.

Clients still basically have no translation support, so it's not really a problem right now on that side, but this would surely impact clients' ability of correctly parsing pages since they'd have to parse these pages differently.

Furthermore, allowing slightly different formats for different languages is not simple to manage. This would also require more work and a different and more complicated approach when linting pages (when linting of other languages is implemented).

A compromise could be to allow commas and other punctuation inside phrases, but not for critical parts of the page like ending periods or ending colons.

Looking to hear from [at least some of] you guys @agnivade @pxgamer @sbrl @waldyrious.

@sbrl
Copy link
Member

sbrl commented Apr 12, 2019

I'd say that we should always ensure that the page format is followed, regardless of language. I think in a recent PR we chose to use plain-ASCII over smart quotes.

@telnetning
Copy link
Author

@sbrl just as you said, translation criteria is important. Indeed, in my opinion, the first thing needed to do is setting a page format.

Page format may be a translation guide like Guides For Free Software Localization Working or others. But anyway, a guide doc is needed.

I adjusted some punctuation marks , such as. to , as all translation guides I have seen do like this. And I didn't adjusted .../--/() as the guide above suggested that.

In addition, I noticed pages/osx also contains many pages. So my patch may should not be merged otherwise there will be two formats.

However, I think the format issue should be discussed again and a guide document is needed for all pages in Chinese.

@agnivade
Copy link
Member

This was my first concern in the original translation issue - #2339 (comment). It is risky to change punctuation characters as some clients may depend on it. I am fine with changing stuff within sentences or tokens. But any trailing characters like : or . should be left alone.

Exactly what @mebeim said

A compromise could be to allow commas and other punctuation inside phrases, but not for critical parts of the page like ending periods or ending colons.

@sbrl
Copy link
Member

sbrl commented Apr 17, 2019

The other thing is that the linter also depends on these characters.

@mebeim
Copy link
Member

mebeim commented Apr 20, 2019

So, @telnetning, could you fix this by keeping the original english punctuation characters for critical parts of the pages (like final description dot and final example description colon)?

I get your point, and also anything in the description is free to be changed (brackets, accents, whatever, not only commas), but those characters are more than needed both for linting purposes and for client compatibility. We could work on allowing those in the future, but it is not really feasible right now.

@telnetning
Copy link
Author

OK, I have understood and agreed it's not the time to bring Chinese punctuation characters into translated text. After all, Usability is more important than aesthetics feeling.
So, I will close this issue, and we can re-discuss this in the future.
Thanks you all again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants