lvresize: add vg to positional arg and example extend #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the positional parameter, it's needed to specify the VG and LV name as in `VG/LV`. As so, add `{{volume_group}}/`.
- Add example to extend LV with `--size +`
- normalize use of extended parameter names (e.g. `--size` instead of `-r`).
- Move shrink example to below extend examples.
- clarify in description it's operating in a logical volume.
navarroaxel
requested changes
Jan 16, 2021
bl-ue
suggested changes
Jan 16, 2021
There was a problem hiding this comment.
Just a grammar change. Otherwise LGTM! (after addressing @navarroaxel's comment)
|
The build for this PR failed with the following error(s): Please fix the error(s) and push again. |
|
The build for this PR failed with the following error(s): Please fix the error(s) and push again. |
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
|
@bl-ue i should have commited your changes instead of doing that directly in the file, im sorry about that |
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
bl-ue
approved these changes
Jan 17, 2021
There was a problem hiding this comment.
Looks good @aaaawwWWWwwwwWWW! ❤️
Pretty soon you could become a collaborator! 😄
navarroaxel
approved these changes
Jan 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VG/LV. As so, add{{volume_group}}/.--size +--resizefsinstead of-r).common/,linux/, etc.)