Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs*: add Chinese translation #5244

Merged
merged 6 commits into from
May 17, 2021

Conversation

CoelacanthusHex
Copy link
Contributor

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2021

CLA assistant check
All committers have signed the CLA.

@CoelacanthusHex CoelacanthusHex marked this pull request as ready for review February 5, 2021 17:31
@bl-ue bl-ue added the translation Translate pages from one language to another. label Feb 5, 2021
@bl-ue bl-ue changed the title btrfs,btrfs-device,btrfs-filesystem,btrfs-subvolume,btrfs-scrub: add Simplified Chinese translation btrfs, btrfs-device, btrfs-filesystem, btrfs-subvolume, btrfs-scrub: add Simplified Chinese translation Feb 5, 2021
@bl-ue bl-ue changed the title btrfs, btrfs-device, btrfs-filesystem, btrfs-subvolume, btrfs-scrub: add Simplified Chinese translation btrfs, btrfs-device, btrfs-filesystem, btrfs-subvolume, btrfs-scrub: add Chinese translation Feb 5, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Feb 5, 2021

Hi @CoelacanthusHex, this is great, but this PR will have to wait a little while, see my PR #5240 for normalizing punctuation across all Chinese pages.

@CoelacanthusHex
Copy link
Contributor Author

ok, I am waiting, and I will correct punctuation in my pr as #5240 do when it be merged

@bl-ue
Copy link
Contributor

bl-ue commented Feb 5, 2021

Please feel free to contribute suggestions to that PR, as I don't know Chinese. I'd love for some help from native Chinese speakers ;)

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CoelacanthusHex, I found a little oversight.

Also, will you please:

  1. Change all colons (including ones at the end of example descriptions) to Chinese colons ()
  2. Change all periods (including ones at the end of more information links) to Chinese periods ()

Thank you!

pages.zh/linux/btrfs-device.md Outdated Show resolved Hide resolved
CoelacanthusHex and others added 2 commits February 7, 2021 21:37
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@CoelacanthusHex
Copy link
Contributor Author

Hi @CoelacanthusHex, I found a little oversight.

Also, will you please:

1. Change all colons (including ones at the end of example descriptions) to Chinese colons (`:`)

2. Change all periods (including ones at the end of more information links) to Chinese periods (`。`)

Thank you!

Done!

@bl-ue
Copy link
Contributor

bl-ue commented Feb 7, 2021

Great. I think this PR will be merged soon, as I find all of the punctuation and formatted well. I especially like what you've done here:
https://github.com/tldr-pages/tldr/pull/5244/files#diff-4a913c56aa1d36868ed6ef85cf4d56a934b94c19d5b650f0e4a90d47fc46fcdfR3,
with the (COW), because that solves an issue I've been having with the Chinese parentheses around English sentences (#5240).

(sorry for the ugly comment 😄)

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoelacanthusHex please apply @navarroaxel's suggestion and these.

See #5244 (comment). We prefer the shorter version.

pages.zh/linux/btrfs-filesystem.md Outdated Show resolved Hide resolved
pages.zh/linux/btrfs-scrub.md Outdated Show resolved Hide resolved
pages.zh/linux/btrfs-subvolume.md Outdated Show resolved Hide resolved
CoelacanthusHex and others added 2 commits February 9, 2021 10:26
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel navarroaxel changed the title btrfs, btrfs-device, btrfs-filesystem, btrfs-subvolume, btrfs-scrub: add Chinese translation btrfs*: add Chinese translation Feb 9, 2021
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CoelacanthusHex!

This reminds me, I should write another page for a btrfs subcommand to keep the ball rolling.

@sbrl
Copy link
Member

sbrl commented Feb 12, 2021

Are we ok to merge here, @bl-ue?

@bl-ue
Copy link
Contributor

bl-ue commented Feb 12, 2021

@sbrl I'd like to wait for a consensus at #5240.

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Feb 28, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Feb 28, 2021

Waiting for #5240. Sorry, I need to get back to that.

@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label Feb 28, 2021
Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @bl-ue is it good to merge?

@bl-ue
Copy link
Contributor

bl-ue commented Mar 14, 2021

#5240 soooorry about this, I need to get back to that ☹️

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Mar 30, 2021
@CoelacanthusHex CoelacanthusHex requested a review from bl-ue March 30, 2021 02:40
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label Mar 30, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Mar 30, 2021

Okay, yes, #5240 will be my first priority (besides PR reviews) 👍🏻

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Apr 15, 2021
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label Apr 15, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2021

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label May 1, 2021
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label May 1, 2021
@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label May 17, 2021
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label May 17, 2021
@marchersimon
Copy link
Collaborator

How about we merge this PR for now and make changes when we're done with #5240? Many people could use the pages in the meantime.

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CoelacanthusHex! I'm terrible sorry that this has taken nearly half a year, especially on your first PR 😖

@bl-ue bl-ue requested a review from marchersimon May 17, 2021 17:35
@CleanMachine1
Copy link
Member

Merging.

@CleanMachine1 CleanMachine1 merged commit 93cafcd into tldr-pages:main May 17, 2021
@bl-ue bl-ue removed the request for review from marchersimon May 17, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants