-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btrfs*: add Chinese translation #5244
btrfs*: add Chinese translation #5244
Conversation
…Simplified Chinese translation
Hi @CoelacanthusHex, this is great, but this PR will have to wait a little while, see my PR #5240 for normalizing punctuation across all Chinese pages. |
ok, I am waiting, and I will correct punctuation in my pr as #5240 do when it be merged |
Please feel free to contribute suggestions to that PR, as I don't know Chinese. I'd love for some help from native Chinese speakers ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CoelacanthusHex, I found a little oversight.
Also, will you please:
- Change all colons (including ones at the end of example descriptions) to Chinese colons (
:
) - Change all periods (including ones at the end of more information links) to Chinese periods (
。
)
Thank you!
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Done! |
Great. I think this PR will be merged soon, as I find all of the punctuation and formatted well. I especially like what you've done here: (sorry for the ugly comment 😄) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CoelacanthusHex please apply @navarroaxel's suggestion and these.
See #5244 (comment). We prefer the shorter version.
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @CoelacanthusHex!
This reminds me, I should write another page for a btrfs subcommand to keep the ball rolling.
Are we ok to merge here, @bl-ue? |
Hi all! This thread has not had any recent activity. |
Waiting for #5240. Sorry, I need to get back to that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @bl-ue is it good to merge?
#5240 soooorry about this, I need to get back to that |
Hi all! This thread has not had any recent activity. |
Okay, yes, #5240 will be my first priority (besides PR reviews) 👍🏻 |
Hi all! This thread has not had any recent activity. |
Hi all! This thread has not had any recent activity. |
Hi all! This thread has not had any recent activity. |
How about we merge this PR for now and make changes when we're done with #5240? Many people could use the pages in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @CoelacanthusHex! I'm terrible sorry that this has taken nearly half a year, especially on your first PR 😖
Merging. |
common/
,linux/
, etc.)