Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espanso: add page #5662

Merged
merged 1 commit into from
Apr 1, 2021
Merged

espanso: add page #5662

merged 1 commit into from
Apr 1, 2021

Conversation

nicokosi
Copy link
Collaborator

@nicokosi nicokosi commented Apr 1, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2021

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

tldr-bot commented Apr 1, 2021

The build for this PR failed with the following error(s):

pages/common/espanso.md:25 MD047/single-trailing-newline Files should end with a single newline character
Error: Parse error on line 20:
...s the package_name- Restart:`espanso
---------------------^
Expecting 'BACKTICK', got 'DASH'
pages/common/espanso.md:3: TLDR004 Command descriptions should end in a period
pages/common/espanso.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters
pages/common/espanso.md:18: TLDR102 Example description probably not properly annotated

Please fix the error(s) and push again.

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label Apr 1, 2021
@tldr-bot
Copy link

tldr-bot commented Apr 1, 2021

The build for this PR failed with the following error(s):

pages/common/espanso.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Apr 1, 2021

The build for this PR failed with the following error(s):

pages/common/espanso.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@bl-ue
Copy link
Contributor

bl-ue commented Apr 1, 2021

@nicokosi if you can, please avoid force-pushing. It's not necessary as we automatically squash commits before merging and it can make reviewing a bit difficult 🙂

@nicokosi
Copy link
Collaborator Author

nicokosi commented Apr 1, 2021

@nicokosi if you can, please avoid force-pushing. It's not necessary as we automatically squash commits before merging and it can make reviewing a bit difficult 🙂

Sorry, I thought it was OK since the PR is a work in progress (draft). 😇
Now stopping force-pushing. 🙂

@nicokosi nicokosi marked this pull request as ready for review April 1, 2021 19:24
@bl-ue
Copy link
Contributor

bl-ue commented Apr 1, 2021

Oh, then yeah it doesn't matter if it's a draft (sorry about that, not too observant on my part :).

@navarroaxel navarroaxel merged commit 46ae3bf into tldr-pages:master Apr 1, 2021
@bl-ue
Copy link
Contributor

bl-ue commented Apr 1, 2021

Welcome to tldr-pages, @nicokosi! ⚡

@nicokosi nicokosi deleted the espanso branch April 2, 2021 05:07
@bl-ue bl-ue mentioned this pull request Apr 15, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants