Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew: make a common page for macOS, Linux and Windows #5693

Merged
merged 6 commits into from
Apr 10, 2021
Merged

brew: make a common page for macOS, Linux and Windows #5693

merged 6 commits into from
Apr 10, 2021

Conversation

nicokosi
Copy link
Collaborator

@nicokosi nicokosi commented Apr 6, 2021

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

nicokosi added 2 commits April 6, 2021 08:18
@nicokosi
brew: merge macos/linux pages to common
067629e 
Commands are the same.
@nicokosi
brew: remove 'leaves' command and focus on main commands
4c09f81 
I feel that brew 'leaves' command is not a basic one.
@nicokosi nicokosi mentioned this pull request Apr 6, 2021
Closed
5 tasks
@nicokosi nicokosi marked this pull request as ready for review April 6, 2021 06:24
nicokosi
nicokosi commented Apr 6, 2021
View reviewed changes
pages/common/brew.md Outdated Show resolved Hide resolved
nicokosi
nicokosi commented Apr 6, 2021
View reviewed changes
pages/common/brew.md Outdated Show resolved Hide resolved
nicokosi
nicokosi commented Apr 6, 2021
View reviewed changes
pages/common/brew.md Outdated Show resolved Hide resolved
nicokosi
nicokosi commented Apr 6, 2021
View reviewed changes
pages/common/brew.md Outdated Show resolved Hide resolved
bl-ue
bl-ue reviewed Apr 6, 2021
View reviewed changes
pages/common/brew.md Outdated Show resolved Hide resolved
@bl-ue bl-ue added new command Issues requesting creation of a new page. page edit Changes to an existing page(s). labels Apr 7, 2021
@nicokosi @bl-ue
Update pages/common/brew.md
ab99cf5 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@nicokosi

This comment has been minimized.

Sign in to view
bl-ue
bl-ue approved these changes Apr 8, 2021
View reviewed changes
pages/common/brew.md Outdated Show resolved Hide resolved
navarroaxel
navarroaxel reviewed Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicokosi. Was the brew outdated example removed for some specific reason?

@nicokosi
Copy link
Collaborator Author

nicokosi commented Apr 9, 2021 •
edited
Loading

Hi @nicokosi. Was the brew outdated example removed for some specific reason?

I took the macOS page as reference and the command brew outdated was not present. Do you think we should keep it?

@navarroaxel
Copy link
Collaborator

@nicokosi I think is useful to know the outdated packages.
I found it in the man page here: https://docs.brew.sh/Manpage#outdated-options-formulacask-

@nicokosi
Copy link
Collaborator Author

nicokosi commented Apr 9, 2021

@nicokosi I think is useful to know the outdated packages.
I found it in the man page here: https://docs.brew.sh/Manpage#outdated-options-formulacask-

Done in 02266ba.

@navarroaxel navarroaxel merged commit b4744ec into tldr-pages:master Apr 10, 2021
@nicokosi nicokosi deleted the common_brew branch April 12, 2021 06:14
@marchersimon marchersimon mentioned this pull request May 2, 2021
Closed
@marchersimon marchersimon mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchersimon marchersimon marchersimon left review comments

@tansiret tansiret tansiret left review comments

@Waples Waples Waples left review comments

@bl-ue bl-ue bl-ue approved these changes

@schneiderl schneiderl schneiderl approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nicokosi @navarroaxel @schneiderl @Waples @tansiret @marchersimon @bl-ue