cowsay: fix commands for zsh

[nicokosi]

Fix commands that fail with zsh due to missing escaping for the exclamation mark:

$ cowsay -f dragon "Hello!"
dquote>

$ uname -a
Darwin **** 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64

$ echo $SHELL
/bin/zsh

$ cowsay -h
cow{say,think} version 3.03, (c) 1999 Tony Monroe
Usage: cowsay [-bdgpstwy] [-h] [-e eyes] [-f cowfile]
      [-l] [-n] [-T tongue] [-W wrapcolumn] [message]

• The PR title conforms to the recommended templates.
• The page follows the content guidelines.

[Waples]

Works fine for me 🤔

tested in bash and fish shells on different machines (Arch Linux, RaspberryPi Os).

unames:
Linux **** 5.11.13-arch1-1 #1 SMP PREEMPT Sat, 10 Apr 2021 20:47:14 +0000 x86_64 GNU/Linux
Linux **** 5.10.17-v7+ #1403 SMP Mon Feb 22 11:29:51 GMT 2021 armv7l GNU/Linux

$  cowsay -f dragon hello!                                                                                                                                                                                 10:27:12
 ________
< hello! >
 --------
      \                    / \  //\
       \    |\___/|      /   \//  \\
            /0  0  \__  /    //  | \ \
           /     /  \/_/    //   |  \  \
           @_^_@'/   \/_   //    |   \   \
           //_^_/     \/_ //     |    \    \
        ( //) |        \///      |     \     \
      ( / /) _|_ /   )  //       |      \     _\
    ( // /) '/,_ _ _/  ( ; -.    |    _ _\.-~        .-~~~^-.
  (( / / )) ,-{        _      `-.|.-~-.           .~         `.
 (( // / ))  '/\      /                 ~-. _ .-~      .-~^-.  \
 (( /// ))      `.   {            }                   /      \  \
  (( / ))     .----~-.\        \-'                 .~         \  `. \^-.
             ///.----..>        \             _ -~             `.  ^-`  ^-_
               ///-._ _ _ _ _ _ _}^ - - - - ~                     ~-- ,.-~
                                                                  /.-~

[nicokosi]

Works fine for me

tested in bash and fish shells on different machines (Arch Linux, RaspberryPi Os).

Thank you @Waples for testing. 👍
In fact, cowsay -f dragon "hello!" does not work with zsh.

[nicokosi]

Commit 06b6a5e fixes commands for zsh replacing double-quotes with single-quotes.

[marchersimon]

Thank you @Waples for testing. In fact, cowsay -f dragon "hello!" does not work with zsh.

Can confirm. !" actually escapes any future exclamation marks for history expansion (!!, !$, ...), and so zsh thinks there's an unterminated quote.

[nicokosi]

(I did a git push --force in order to edit the commit message: I mentioned the zsh specificity) 😇

[marchersimon]

Why?

[nicokosi]

It fails with zsh(but I forgot to change for single quotes like other examples). 😇

[navarroaxel]

Can we just remove the ! from the text in the examples? 😂

[marchersimon]

That would be the easy way 😄.

[nicokosi]

Can we just remove the ! from the text in the examples?

That's cheating. https://en.wikipedia.org/wiki/%22Hello,_World!%22_program 😉

Why not? I don't care but the current fix ('Hello world!') is the closest to the original examples.

[marchersimon]

How about we leave everything as is and add

> In the Z-Shell !" has to be replaced with \!"

to the command description?

But then I'm wondering if that's even worth it. ! has to be escaped almost always with the exception in bash, when it's at the end of a string. Adding that note for this might seem a bit too trivial.

[nicokosi]

How about we leave everything as is and add

In the Z-Shell !" has to be replaced with \!"

to the command description?

But then I'm wondering if that's even worth it. ! has to be escaped almost always with the exception in bash, when it's at the end of a string. Adding that note for this might seem a bit too trivial.

IMHO, it's better to choose a simple example that works for all shells (I like Hello world! but Hello world is OK for me, too). ☺️

[marchersimon]

I think we should keep the examples as generic as possible and since !" isn't a problem of cowsay it would fit better in a zsh related page.

[sbrl]

Hey there! I've got a minor suggestion below, but in terms of the exclamation merk issue I recommend that we remove the exclamation mark altogether. It can also pose an issue in Bash depending on the configuration of the shell if not quotes.

In tldr pages we aim for simplicity, and it sounds like including the exclamation mark would increase the complexity of the page.

[marchersimon]

@nicokosi I think we should move back to double quotes too.

[nicokosi]

@nicokosi I think we should move back to double quotes too.

Done in e4125a2.

[bl-ue]

 _______ 
< LGTM! >
 ------- 
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||