Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp: sync French translations with English page (remove "--parents") #5805

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

nicokosi
Copy link
Collaborator

Should fix a fr warning from https://lukwebsforge.github.io/tldri18n/.

Remove the "--parents" command from the French page since:
- it is not present in the English page ;
- it is not a common option but a Linux one.
@marchersimon
Copy link
Collaborator

marchersimon commented Apr 21, 2021

Seems like pages.fr/common/cp.md got translated from pages/linux/cp.md instead of pages/common/cp.md. The common version uses -R and the linux version uses -r, but -R is also valid in linux. So I think it would be the best to just delete the linux page and instead of removing --parents from the french translation we should add it to the english version.

@marchersimon marchersimon added page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Apr 21, 2021
@marchersimon
Copy link
Collaborator

marchersimon commented Apr 21, 2021

Also all cp pages still use the short form for their arguments, even though there are long forms available for all

@bl-ue
Copy link
Contributor

bl-ue commented Apr 21, 2021

Yeah, a lot of the pages for essential commands still use short options 🤷🏻 they ought to be fixed.

@nicokosi
Copy link
Collaborator Author

Seems like pages.fr/common/cp.md got translated from pages/linux/cp.md instead of pages/common/cp.md. The common version uses -R and the linux version uses -r, but -R is also valid in linux. So I think it would be the best to just delete the linux page and instead of removing --parents from the french translation we should add it to the english version.

OK for the history but I am not sure it's a good thing to document common options that are not (common). 💭

@marchersimon
Copy link
Collaborator

--parents is comon, it just isn't listed in common/cp.md. So, the command is the same on all platforms.

@nicokosi
Copy link
Collaborator Author

--parents is comon, it just isn't listed in common/cp.md. So, the command is the same on all platforms.

Well, not on macOS, visibly:

$ uname -v
Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64

$ cp --parents a/b/c /tmp/dummyFolder

cp: illegal option -- -
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory

@marchersimon
Copy link
Collaborator

Oh, sorry then. In this case the change seems fine. Thanks.

@nicokosi
Copy link
Collaborator Author

Also all cp pages still use the short form for their arguments, even though there are long forms available for all

You're right. I think it should be done in another pull request (I will maybe do it 😇).

@bl-ue bl-ue merged commit 9e4dbe7 into tldr-pages:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants