Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add @ivanhercaz to past organization members #5975

Closed

Conversation

marchersimon
Copy link
Collaborator

I created a new "Past orginazation members" section, as described in the COMMUNITY-ROLES and added a description. (However it says the the section should be called "Past organization owners". Probably a typo, I'll fix that in a PR).

Closes #5932

@marchersimon marchersimon added the community Issues/PRs dealing with role changes and community organization. label May 16, 2021
CleanMachine1
CleanMachine1 previously approved these changes May 16, 2021
@CleanMachine1 CleanMachine1 self-requested a review May 16, 2021 19:37

## Past organization members

Organization members who have been inactive for some time, but still have write access to all the repositories in the tldr-pages organization and are welcome back any time to return to their old role.
Copy link
Member

@CleanMachine1 CleanMachine1 May 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Organization members who have been inactive for some time, but still have write access to all the repositories in the tldr-pages organization and are welcome back any time to return to their old role.
Organization members who have been inactive for some time, still have write access to all the repositories in the tldr-pages organization. After losing organization status, previous members are welcome back any time to return to their old role.

Copy link
Contributor

@bl-ue bl-ue May 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

losing is really too negative, I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Organization members who have been inactive for some time, but still have write access to all the repositories in the tldr-pages organization and are welcome back any time to return to their old role.
Organization members who have been inactive for some time, still have write access to all the repositories in the tldr-pages organization. After releasing organization status, previous members are welcome back any time to return to their old role.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just "removing"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

releasing is less negative than removing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I completely missed that @marchersimon. I think this is fine as-is?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should put both past organization members and owners to the section Past organization owners?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops! I've got confused. I'm not sure whether we'd want separate sections or not? Maybe 1 as Past organization owners?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with separate sections for now. We can always change it later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchersimon could you resolve the conflicts?

@bl-ue bl-ue requested a review from waldyrious May 16, 2021 20:15
@CleanMachine1 CleanMachine1 dismissed their stale review May 16, 2021 20:27

still changes to be made/in question

@waldyrious
Copy link
Member

This PR will likely interact with broader changes we've been discussing for the role management processes, but I won't be able to work on those until about 2 weeks from now. Feel free to merge it if consensus emerges in the meantime. Otherwise, I'd be happy to take a deeper look at it at that time.

@bl-ue
Copy link
Contributor

bl-ue commented May 16, 2021

Two weeks is June — I don't see any particular reason not to wait.

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Jun 23, 2021
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label Jun 23, 2021
@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Jul 20, 2021
@github-actions
Copy link

Hi everyone.
This thread is being closed as there was no response to the previous prompt.
However, please leave a comment whenever you're ready to resume, so the thread can be reopened.
Thanks again!

@github-actions github-actions bot closed this Aug 20, 2021
@marchersimon marchersimon deleted the ivanhercaz-maintainers branch November 7, 2021 17:07
sebastiaanspeck added a commit that referenced this pull request Sep 21, 2024
#5932 was accepted by @ivanhercaz, but he was never removed from the organisation. #5975 was closed, without moving @ivanhercaz correctly. This PR fixes this for historical reasons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization. waiting Issues/PRs with Pending response by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove organization member: @ivanhercaz
6 participants