Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moe: add page #6350

Merged
merged 8 commits into from
Aug 23, 2021
Merged

moe: add page #6350

merged 8 commits into from
Aug 23, 2021

Conversation

pixelcmtd
Copy link
Member

@pixelcmtd pixelcmtd commented Aug 13, 2021 •
edited
Loading

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Closes #6347.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Aug 13, 2021
navarroaxel
navarroaxel reviewed Aug 13, 2021
View reviewed changes
pages/common/moe.md Outdated Show resolved Hide resolved
pages/common/moe.md Outdated Show resolved Hide resolved
pages/common/moe.md Outdated Show resolved Hide resolved
marchersimon
marchersimon approved these changes Aug 13, 2021
View reviewed changes
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@pixelcmtd pixelcmtd mentioned this pull request Aug 13, 2021
Merged
blueskyson
blueskyson approved these changes Aug 15, 2021
View reviewed changes
Copy link
Member

@blueskyson blueskyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CleanMachine1
CleanMachine1 reviewed Aug 15, 2021
View reviewed changes
pages/common/moe.md Outdated Show resolved Hide resolved
navarroaxel
navarroaxel reviewed Aug 15, 2021
View reviewed changes
pages/common/moe.md Outdated Show resolved Hide resolved
pages/common/moe.md Outdated Show resolved Hide resolved
pixelcmtd and others added 2 commits August 16, 2021 01:48
@pixelcmtd @navarroaxel
Update pages/common/moe.md
7d8bf42 
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@pixelcmtd @navarroaxel
i always forget this
a097e2d 
fml

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
navarroaxel
navarroaxel requested changes Aug 17, 2021
View reviewed changes
pages/common/moe.md Outdated Show resolved Hide resolved
@pixelcmtd @navarroaxel
ok
bdd3413 
naja kann man machen

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@navarroaxel navarroaxel merged commit 34e1796 into tldr-pages:main Aug 23, 2021
@CleanMachine1 CleanMachine1 mentioned this pull request Aug 26, 2021
Closed
@pixelcmtd pixelcmtd deleted the moe branch August 28, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 left review comments

@marchersimon marchersimon marchersimon approved these changes

@blueskyson blueskyson blueskyson approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page request: moe
5 participants
@pixelcmtd @navarroaxel @blueskyson @marchersimon @CleanMachine1