Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bootstrap5 #164

Merged
merged 3 commits into from
Aug 29, 2023
Merged

add bootstrap5 #164

merged 3 commits into from
Aug 29, 2023

Conversation

otwn
Copy link
Contributor

@otwn otwn commented Aug 26, 2023

using CDN version of bootstrap5, bootstrap icon, and FontAwesome 6.

@tlienart
Copy link
Owner

tlienart commented Aug 26, 2023

That's awesome!! tried locally and it's great; thanks a lot for this

two very small changes before merging this:

  1. could you bump up the version to 0.10 so we can release this?
  2. could you remove Franklin in the deps? technically Franklin is not a dep of FranklinTemplates (not that it matters a ton but it avoids circular stuff when doing dev work)

🙌

@otwn
Copy link
Contributor Author

otwn commented Aug 26, 2023

I hope this works. Thanks

@tlienart
Copy link
Owner

Thanks a lot!

@tlienart tlienart merged commit 88078bb into tlienart:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants