Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: support loading custom vase in +do-load #3361

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Mar 25, 2024

Was using this library for my own purposes recently and found that it offered no built-in affordance for modifying state or injecting state wholesale. Since +on-load gets called with a vase, seems appropriate for +do-load to accept that as an argument.

This way, state migrations may be tested, and agent state may be created ex-nihilo instead of needing to come about strictly through the normal lifecycle.

We take a (unit vase) so that it remains easy to fall back to +on-save's output.

(Includes some tiny stylistic touch-ups to the library as well.)

This way, state migrations may be tested, and agent state may be created
ex-nihilo instead of needing to come about strictly through the normal
lifecycle.
@Fang- Fang- requested a review from arthyn March 25, 2024 18:08
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice lgtm

@arthyn arthyn merged commit 17746ef into develop Mar 28, 2024
1 check passed
@arthyn arthyn deleted the m/lta-load-custom-state branch March 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants