Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit: make useMyLastMessage more performant #3370

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

patosullivan
Copy link
Member

@patosullivan patosullivan commented Mar 27, 2024

Rewrote useMyLastMessage to be used only for chat channels, added useMyLastReply to be used only for replies in channels. Made myLastMessage a prop for chatInput, we now call the hook from whatever the parent of ChatInput is.

Noticed/remembered this while looking into perf via the profiler elsewhere.

Fixes LAND-1733

Copy link

linear bot commented Mar 28, 2024

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthyn arthyn merged commit 232f54f into develop Mar 28, 2024
1 check passed
@arthyn arthyn deleted the po/improve-last-message-perf branch March 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants