chat: include $whom in %writ-response mark #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us specify the chat that the writ response happened in/for, which cannot otherwise be known if you're subscribing to the / "firehose" endpoint as opposed to an individual, specific chat. We expect to get away with just tacking it on, because nothing on our backend listens for this mark, it's not used in scry endpoints, and the json is "backwards compatible" in the sense that it just has an additional field on the top-level object now. Closes TLON-1880 again.
latter-bolden
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us specify the chat that the writ response happened in/for, which cannot otherwise be known if you're subscribing to the / "firehose" endpoint as opposed to an individual, specific chat.
We expect to get away with just tacking it on, because nothing on our backend listens for this mark, it's not used in scry endpoints, and the json is "backwards compatible" in the sense that it just has an additional field on the top-level object now.
Closes TLON-1880 again.