Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activity: don't mark read if tab not focused and automatically mark read at chat bottom #3771

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jul 18, 2024

This didn't have an issue, but it was old behavior we had that I think is better than what's currently in there. Basically there's three situations:

  • tab is out of focus, so don't do any read marking and let them accumulate
  • tab is in focus, and we're at the bottom of the channel, automatically mark read w/o showing markers
  • tab is in focus, but we're not at the bottom of the channel, don't automatically mark read, let the normal "seeing" trigger mark read

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@jamesacklin
Copy link
Member

Cool, this makes sense. No need to flash the blue separator if you're actively watching the channel in focus.

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes sense.

@arthyn arthyn merged commit b25b9ec into staging Jul 19, 2024
1 check passed
@arthyn arthyn deleted the hm/better-auto-reads branch July 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants