-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activity: fix init unreads #3797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like what we reviewed out of band yesterday. Nothing serious, just some small clean-up things.
Co-authored-by: fang <git@fang.io>
Co-authored-by: fang <git@fang.io>
Co-authored-by: fang <git@fang.io>
Co-authored-by: fang <git@fang.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TLON-2447 by adding a new state transition that will run a fix. The fix looks for any DM or channel sources with only one event which should be either
%dm-invite
or%chan-init
and sets the floor to thelast-read
time from the old agents. If this is actually an invite pending, then it will stay unread which is what we want. If it's not pending and they had in fact previously interacted and read that channel, then it will be marked read.Unfortunately, to call these migration methods I had to factor them out to be pure so that we could call them on old state. Sync reads tests still pass, going to write some for this fix scenario.
PR Checklist