tests: various /lib/test-agent improvements #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you forgot to initialize the agent core to test against, we would run with the bunt of $agent:gall, which is a core that just silently succeeds. Here, we put a skeleton agent into the continuation state, so that any invocations crash (and show a high-priority printf warning you of this fact).
In rare cases, the "mare" being evaluated may produce failure, but only provide the empty tang. /ted/test works only with tangs, and considers an empty tang to be success. So, here, we catch that case, and produce a non-empty tang instead.
For certain tests it's common to switch back and forth between different simulated callers frequently. Being able to wrap calls with (do-as ~pel) or similar makes doing so much more ergonomic.
arthyn
approved these changes
Nov 7, 2024
| @@ -327,6 +347,17 @@ | |||
| |= s=state | |||
| &+[~ s(scry f)] | |||
| :: | |||
| ++ do-as :: temporary src.bowl | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, failing to initialize/set the agent core prior to running your tests could've resulted in false successes. Here we make sure that there's always a crashing skeleton core there, and that crashes with empty traces still result in failing tests.
Additionally, we add a
+do-ashelper for temporarily changing thesrc.bowl. Very convenient for tests that simulate multiple parties interacting with the same agent.