Improve Windows support and add Visual Studio NMake Makefiles #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/libthai.c:
* src/thbrk/brk-common.c:
- Instead define a DLLMain that does the same thing when libthai
is built as a DLL, on DLL_PROCESS_DETACH. Ensure that tests
builds as well since src/thbrk/brk-common.c is also used.
* src/thbrk/brk-common.c:
- Deduce location of DLL or statically-linked EXE and construct
path dynamically where thbrk.tri can be loaded.
* configure.ac:
* Makefile.am:
* win32/*:
- Add a set of NMake Makefiles for Visual Studio 2008 and later,
for building libthai as a DLL as well as the pkg-config file.
Buliding the dictionary file and tests are also supported.
Add detection logic for ARM64 builds, since we can support Windows 10+ on ARM64 with the appropriate Compiler/Linker flags.
Make sure that things are set apart from the 2019 builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This attempts to improve Windows support for libthai in the following ways:
Make the code buildable on Visual Studio. Notably make use of DllMain() using DLL_PROCESS_DETACH to make up for the GCC/CLang-only __attribute((destructor)).
Do not hardcode the location of thbrk.tri on native Windows (non-Cygwin) builds. This at least partially fixes issue Crashing on Windows #7.
Add a set of NMake Makefiles that can be used on Visual Studio 2008 and later to build libthai as a DLL with its pkg-config file, with support to build thbrk.tri and to build and run the test programs.
With blessings, thank you!