Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: set explicit 1.22 version in go.mod #727

Merged
merged 1 commit into from
Mar 31, 2024
Merged

all: set explicit 1.22 version in go.mod #727

merged 1 commit into from
Mar 31, 2024

Conversation

eliben
Copy link
Collaborator

@eliben eliben commented Mar 27, 2024

https://go.dev/ref/mod#go-mod-file-go


go directive

A go directive indicates that a module was written assuming the semantics of a given version of Go. The version must be a valid Go version, such as 1.9, 1.14, or 1.21rc1.

The go directive sets the minimum version of Go required to use this module. Before Go 1.21, the directive was advisory only; now it is a mandatory requirement: Go toolchains refuse to use modules declaring newer Go versions.


Per golang/go#62278 (comment), go 1.22 is insufficient and may return errors for "go1.22 toolchain not available"

@eliben eliben requested a review from tmc March 27, 2024 13:12
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc merged commit 319b863 into main Mar 31, 2024
3 checks passed
@tmc tmc deleted the gomod branch March 31, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants