Update to React@16.4 and add a test for strict mode

This test is a reproduction for tomkp#309 and so is currently failing.

There is some complexity in making it work but it reproduces the problem.

package.json

@@ -62,8 +62,8 @@
     "mochify": "^5.8.0",
     "mochify-istanbul": "^2.4.2",
     "prettier": "^1.13.5",
-    "react": "^15.6.1",
-    "react-dom": "^15.6.1",
+    "react": "^16.4.2",
+    "react-dom": "^16.4.2",
     "rimraf": "^2.6.2",
     "rollup": "^0.60.7",
     "rollup-plugin-babel": "^3.0.4",

test/assertions/Asserter.js

@@ -217,5 +217,10 @@ export default (jsx, renderToDom = false) => {
       expect(primary.props.size).to.equal(undefined);
       expect(secondary.props.size).to.equal(50);
     },
+
+    assertPaneWidthChange(newJsx, expectedWidth, pane = 'first') {
+      updateComponent(newJsx);
+      return assertPaneStyles({ width: expectedWidth }, pane);
+    },
   };
 };

test/default-split-pane-tests.js

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { StrictMode } from 'react';
 import chai from 'chai';
 import spies from 'chai-spies';
 
@@ -145,7 +145,6 @@ describe('Component updates', () => {
       <div>two</div>
     </SplitPane>
   );
-
   it('unsets the width on the non-primary panel when first', () => {
     asserter(splitPane1).assertPrimaryPanelChange(
       splitPane2,
@@ -161,4 +160,30 @@ describe('Component updates', () => {
       'first'
     );
   });
+
+  it('updates the width of first panel when updating size, in strict mode (#309)', () => {
+    // For some reason StrictMode renders to null if it is the root of the jsx,
+    // and we also need the root to be a class-based component. So this is just a complicated
+    // way of getting around this problem.
+    class Div extends React.Component {
+      render() {
+        return <div>{this.props.children}</div>;
+      }
+    }
+    const paneWithWidth = size => (
+      <Div>
+        <StrictMode>
+          <SplitPane primary="first" size={size}>
+            <div>one</div>
+            <div>two</div>
+          </SplitPane>
+        </StrictMode>
+      </Div>
+    );
+
+    asserter(paneWithWidth(100)).assertPaneWidthChange(
+      paneWithWidth(200),
+      '200px'
+    );
+  });
 });

yarn.lock

@@ -1809,14 +1809,6 @@ create-hmac@^1.1.0, create-hmac@^1.1.2, create-hmac@^1.1.4:
     safe-buffer "^5.0.1"
     sha.js "^2.4.8"
 
-create-react-class@^15.6.0:
-  version "15.6.3"
-  resolved "https://registry.yarnpkg.com/create-react-class/-/create-react-class-15.6.3.tgz#2d73237fb3f970ae6ebe011a9e66f46dbca80036"
-  dependencies:
-    fbjs "^0.8.9"
-    loose-envify "^1.3.1"
-    object-assign "^4.1.1"
-
 cross-env@^5.2.0:
   version "5.2.0"
   resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-5.2.0.tgz#6ecd4c015d5773e614039ee529076669b9d126f2"
@@ -2470,7 +2462,7 @@ fast-levenshtein@~2.0.4:
   version "2.0.6"
   resolved "https://registry.yarnpkg.com/fast-levenshtein/-/fast-levenshtein-2.0.6.tgz#3d8a5c66883a16a30ca8643e851f19baa7797917"
 
-fbjs@^0.8.9:
+fbjs@^0.8.16:
   version "0.8.17"
   resolved "https://registry.yarnpkg.com/fbjs/-/fbjs-0.8.17.tgz#c4d598ead6949112653d6588b01a5cdcd9f90fdd"
   dependencies:
@@ -4387,7 +4379,7 @@ prompt@~0.2.14:
     utile "0.2.x"
     winston "0.8.x"
 
-prop-types@^15.5.10, prop-types@^15.5.4, prop-types@^15.6.1:
+prop-types@^15.5.10, prop-types@^15.5.4, prop-types@^15.6.0, prop-types@^15.6.1:
   version "15.6.2"
   resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.2.tgz#05d5ca77b4453e985d60fc7ff8c859094a497102"
   dependencies:
@@ -4483,14 +4475,14 @@ rc@^1.1.7:
     minimist "^1.2.0"
     strip-json-comments "~2.0.1"
 
-react-dom@^15.6.1:
-  version "15.6.2"
-  resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-15.6.2.tgz#41cfadf693b757faf2708443a1d1fd5a02bef730"
+react-dom@^16.4.2:
+  version "16.4.2"
+  resolved "https://registry.yarnpkg.com/react-dom/-/react-dom-16.4.2.tgz#4afed569689f2c561d2b8da0b819669c38a0bda4"
   dependencies:
-    fbjs "^0.8.9"
+    fbjs "^0.8.16"
     loose-envify "^1.1.0"
-    object-assign "^4.1.0"
-    prop-types "^15.5.10"
+    object-assign "^4.1.1"
+    prop-types "^15.6.0"
 
 react-lifecycles-compat@^3.0.4:
   version "3.0.4"
@@ -4502,15 +4494,14 @@ react-style-proptype@^3.0.0:
   dependencies:
     prop-types "^15.5.4"
 
-react@^15.6.1:
-  version "15.6.2"
-  resolved "https://registry.yarnpkg.com/react/-/react-15.6.2.tgz#dba0434ab439cfe82f108f0f511663908179aa72"
+react@^16.4.2:
+  version "16.4.2"
+  resolved "https://registry.yarnpkg.com/react/-/react-16.4.2.tgz#2cd90154e3a9d9dd8da2991149fdca3c260e129f"
   dependencies:
-    create-react-class "^15.6.0"
-    fbjs "^0.8.9"
+    fbjs "^0.8.16"
     loose-envify "^1.1.0"
-    object-assign "^4.1.0"
-    prop-types "^15.5.10"
+    object-assign "^4.1.1"
+    prop-types "^15.6.0"
 
 read-only-stream@^2.0.0:
   version "2.0.0"