Use Terraform to provision Cognito resources, rather than shell script #157
Conversation
| default_email_option = "CONFIRM_WITH_LINK" | ||
| } | ||
| password_policy = { | ||
| minimum_length = 6 |
There was a problem hiding this comment.
Update this to 8 (Gitlab requires 8 characters and Jazz UI enforces it)
There was a problem hiding this comment.
Done. It might be a good idea to strengthen the requirements for symbols and mixed case as well, but I was just trying to match what was already defined.
| @@ -1,15 +0,0 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Is this not required anymore because terraform destroy will take care of it?
| if [ $? -gt 0 ] | ||
| then | ||
| date | ||
| print_error "$message....Failed" |
There was a problem hiding this comment.
Finally we can rollback on failures, super cool!
There was a problem hiding this comment.
It seems to work OK in my testing. It doesn't undo everything, but it will destroy all AWS resources Terraform created, which is most of what people actually would want since those will cost money.
|
I think this fixes #154 to some degree. It doesn't fail immediately, but it will note the failure and roll back AWS resource creation. |
Use Terraform to provision Cognito resources, rather than shell script Former-commit-id: c9bfab7
Just putting this here so it can be reviewed, as this contains a Terraform version bump it probably should not be merged until the 1.4.1. release goes out.
This
terraform initto automatically fetch and install external provider modules (awsandnull)providers.tfto lock down the above-mentioned external provider versions.terraform applyexit code and automatically runsterraform destroyfor all resources created up to that point in AWS if that command fails, so we don't leave stray AWS resources out there.Hardcoded the AWS provider version to ">= 1.14", since 1.14 has this required fix.