Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different build paths for Xcode 8 and 9 #82

Closed
Zeotyn opened this issue Jul 5, 2017 · 11 comments
Closed

Different build paths for Xcode 8 and 9 #82

Zeotyn opened this issue Jul 5, 2017 · 11 comments

Comments

@Zeotyn
Copy link

Zeotyn commented Jul 5, 2017

Hi there,

I'm looking for an option to build and upload different xcode-version builds of the same framework into the same bucket.

This might be possible by storing different buildtypes in subpaths in the same buckets and up-/downloading with a configuration path like:

rome upload --buildpath DEFINED_IN_ROMEFILE
rome download --buildpath DEFINED_IN_ROMEFILE

The buildpath could simply be defined within the romefile.

Does a similar feature already exist?

**Rome version:** latest
**OS and version:** macOS 10.12.5

Cheers

@tmspzz
Copy link
Owner

tmspzz commented Jul 5, 2017

Hi, @Zeotyn

thanks for opining an issue.

This feature does not exist at the moment. I'm assuming that what you really want is not the Xcode Version but rather the Swift version. Is that correct?

Edit:

The fastest way I can think of right now is to add a flag similar to what you suggested for all commands. Something like --cache-prefix. This will basically be transparent to any Swift/Xcode/Whatever versioning.

The --cache-prefix will be prefixed in front of the cache directories. It will be left to the user to use this correctly.

$ ls ~/Library/Caches/Rome/
Xcode_8/Alamofire
Xcode_9/Alamofire
Swift_2_1/Alamofire
Alamofire
rome upload --cache-prefix Xcode_8
rome download --cache-prefix Xcode_8
rome list --cache-prefix Xcode_8

@Zeotyn
Copy link
Author

Zeotyn commented Jul 5, 2017

Sounds great! I meant Swift versions, sorry. Btw. thanks for this fast reply!

@tmspzz
Copy link
Owner

tmspzz commented Jul 10, 2017

@Zeotyn Please try pre-release https://github.com/blender/Rome/releases/tag/v0.12.0.29

Please report any bugs, if it works as intended I will make a full release.

@kaybutter
Copy link

The prefix doesn't seem to be consistently applied to the local cache path. It's used for lookup but the downloaded files are not copied to the right location yet:

▸ Error: could not find quick.dSYM in local cache at : /Users/fhqwhgads/Library/Caches/Rome/Xcode9/quick/iOS/quick.framework.dSYM-v1.1.0.zip
▸ Downloaded quick.dSYM from: Xcode9/quick/iOS/quick.framework.dSYM-v1.1.0.zip
▸ Copied quick.dSYM to: /Users/fhqwhgads/Library/Caches/Rome/quick/iOS/quick.framework.dSYM-v1.1.0.zip

@tmspzz
Copy link
Owner

tmspzz commented Jul 11, 2017

@kaybutter thanks, I'll check. I think it might be just an error in the logs.

@kaybutter
Copy link

Nope. It actually overwrote the old cache, that's how I noticed.

@tmspzz
Copy link
Owner

tmspzz commented Jul 11, 2017

@Zeotyn
Copy link
Author

Zeotyn commented Jul 11, 2017

@blender great and very fast thanks!

▸ Error: could not find quick in local cache at : /Users/fhqwhgads/Library/Caches/Rome/Xcode9/quick/iOS/quick.framework-v1.1.0.zip
▸ Downloaded quick from: Xcode9/quick/iOS/quick.framework-v1.1.0.zip
▸ Copied quick to: /Users/fhqwhgads/Library/Caches/Rome/Xcode9/quick/iOS/quick.framework-v1.1.0.zip

@tmspzz
Copy link
Owner

tmspzz commented Jul 11, 2017

@Zeotyn @kaybutter no problem. I'll test a little more and then make a full release via brew

@tmspzz
Copy link
Owner

tmspzz commented Jul 11, 2017

FYI don't use that tag there is one more bug when uploading .version files. Wait for the full release. It will happen shortly

@tmspzz
Copy link
Owner

tmspzz commented Jul 11, 2017

New version is out:

get it at https://github.com/blender/Rome/releases/tag/v0.12.0.31 or run brew update rome

@tmspzz tmspzz closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants