Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.0.31 - Spurius Lartius #84

Merged
merged 10 commits into from
Jul 11, 2017
Merged

v0.12.0.31 - Spurius Lartius #84

merged 10 commits into from
Jul 11, 2017

Conversation

tmspzz
Copy link
Owner

@tmspzz tmspzz commented Jul 10, 2017

@hlintBot
Copy link

hlintBot commented Jul 10, 2017

4 Warnings
⚠️ Big PR
⚠️ src/Lib.hs#L533 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:958:5
⚠️ src/Lib.hs#L533 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension ++ ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9

Why Not

1Combine with src/Lib.hs:581:5
⚠️ src/Utils.hs#L256 - Found Use &&&

1zip
2  (map (repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     frameworkNames)
4  (map _frameworkVersion frameworkNames)

Why Not

1map
2  ((repoNameForFrameworkName reverseRomeMap . _frameworkName)
3     Control.Arrow.&&& _frameworkVersion)
4  frameworkNames

Generated by 🚫 Danger

tmspzz added 4 commits July 11, 2017 00:47
* Use CachePrefix when saving artifacts after download

* Move CachePrefix parameter to reader environment in save*toLocalCache functions.
@tmspzz tmspzz changed the title v0.12.0.29 - Spurius Lartius v0.12.0.31 - Spurius Lartius Jul 11, 2017
@tmspzz tmspzz merged commit badfc9d into master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants