Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Danger.Systems to run HLint #81

Merged
merged 2 commits into from
Jul 5, 2017
Merged

Add Danger.Systems to run HLint #81

merged 2 commits into from
Jul 5, 2017

Conversation

tmspzz
Copy link
Owner

@tmspzz tmspzz commented Jul 3, 2017

No description provided.

Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 3, 2017
Repository owner deleted a comment from RomeBot Jul 4, 2017
Repository owner deleted a comment from RomeBot Jul 4, 2017
Repository owner deleted a comment from RomeBot Jul 4, 2017
Repository owner deleted a comment from RomeBot Jul 4, 2017
Repository owner deleted a comment from RomeBot Jul 4, 2017
Repository owner deleted a comment from RomeBot Jul 4, 2017
Repository owner deleted a comment from hlintBot Jul 5, 2017
Repository owner deleted a comment from hlintBot Jul 5, 2017
Repository owner deleted a comment from hlintBot Jul 5, 2017
@hlintBot
Copy link

hlintBot commented Jul 5, 2017

2 Warnings
⚠️ src/Lib.hs#L485 - Found Reduce duplication

1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
3frameworkDirectory
4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
5

Why Not

1Combine with src/Lib.hs:900:5
⚠️ src/Lib.hs#L485 - Found Reduce duplication

 1frameworkNameWithFrameworkExtension = appendFrameworkExtensionTo f
 2platformBuildDirectory = carthageBuildDirectoryForPlatform platform
 3frameworkDirectory
 4  = platformBuildDirectory </> frameworkNameWithFrameworkExtension
 5dSYMNameWithDSYMExtension
 6  = frameworkNameWithFrameworkExtension ++ ".dSYM"
 7dSYMdirectory
 8  = platformBuildDirectory </> dSYMNameWithDSYMExtension
 9

Why Not

1Combine with src/Lib.hs:532:5

Generated by 🚫 Danger

@tmspzz tmspzz changed the title [WIP] Danger Add Danger.Systems to run HLint Jul 5, 2017
@tmspzz tmspzz changed the base branch from master to develop July 5, 2017 10:36
@tmspzz tmspzz merged commit 40203ab into develop Jul 5, 2017
@tmspzz tmspzz deleted the feature/danger branch July 5, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants