refactor function to get pr number #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnyo43
commented
Mar 20, 2024
| @@ -7,12 +7,6 @@ inputs: | |||
| description: 'a github access token' | |||
| required: true | |||
| default: ${{ github.token }} | |||
| pr_url: | |||
|
Hey @tnyo43! It seems the discussion is dragging on. Perhaps instead of text communication, you could try having a conversation via face-to-face or video call, or even try mob programming? number of commentsthe number of the comments is 4 threshold: 4 |
|
test comment getting pr number works fine 👍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update getting pr number logic.
context.payload.issue.numbercontext.payload.pull_request.numberI checked it works on tnyo43/github-action-take-issue-number-on-issue-comment#3