Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extrapolate not used in tracking #165

Open
freemansw1 opened this issue Jul 25, 2022 · 3 comments
Open

extrapolate not used in tracking #165

freemansw1 opened this issue Jul 25, 2022 · 3 comments
Labels
bug Code that is failing or producing the wrong result
Milestone
Beyond v1.6

Comments

@freemansw1
Copy link
Member

I think that this gets back to the discussion in #149, but the extrapolate parameter is not currently used in linking_trackpy. We should probably warn users when using it at the moment until #149 is resolved. I'm going to ping Max to see if he has thoughts on #149.
@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Jul 25, 2022
@snilsn
Copy link
Collaborator

snilsn commented Jul 27, 2022

Agreed, and I think the same applies to the order parameter.

@freemansw1 freemansw1 added this to the Version 1.4 milestone Sep 9, 2022
@freemansw1
Copy link
Member Author

freemansw1 commented Sep 9, 2022 •
edited
Loading

After some discussion with users, I think we should take the following actions on this:

  • Raise a NotImplementedError when users try to set extrapolate in v1.4
  • Implement extrapolation (rather interpolation, really) and fix the fill_gaps function at some point in the future

Please, let me know thoughts!

This was referenced Sep 9, 2022
Closed
Merged
@freemansw1
Copy link
Member Author

#177 will fix the first part of this for v1.4. I've moved this now to v1.6 for the second part of the issue.

@freemansw1 freemansw1 modified the milestones: Version 1.4, Version 1.6 Sep 12, 2022
@JuliaKukulies JuliaKukulies mentioned this issue Dec 11, 2022
Closed
@freemansw1 freemansw1 modified the milestones: Version 1.6, Version 1.5.x Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Milestone
Beyond v1.6
Development

No branches or pull requests
3 participants
@freemansw1 @JuliaKukulies @snilsn