Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise NotImplementedError when using extrapolation #177

Merged

Conversation

freemansw1
Copy link
Member

Resolves the first part of #165 by raising a NotImplementedError when users try to use extrapolation.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Sep 12, 2022
@freemansw1 freemansw1 added this to the Version 1.4 milestone Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #177 (be85f36) into RC_v1.4.0 (955e799) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           RC_v1.4.0     #177      +/-   ##
=============================================
+ Coverage      34.93%   35.00%   +0.06%     
=============================================
  Files             11       11              
  Lines           2098     2100       +2     
=============================================
+ Hits             733      735       +2     
  Misses          1365     1365              
Flag Coverage Δ
unittests 35.00% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tobac/tracking.py 65.13% <100.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me - approved!

Copy link
Collaborator

@kelcyno kelcyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, glad to approve.

@freemansw1
Copy link
Member Author

Given the small nature of the changes and the two approving reviews, I am merging this. Thanks for the quick reviews, @kelcyno and @JuliaKukulies!

@freemansw1 freemansw1 merged commit 9635f53 into tobac-project:RC_v1.4.0 Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants