Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow spectral filtering of input data #137

Merged
merged 26 commits into from
Jul 23, 2022
Merged

Allow spectral filtering of input data #137

merged 26 commits into from
Jul 23, 2022

Commits on Jun 8, 2022

  1. add spectral filtering function to utils

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    9eefd15 View commit details
    Browse the repository at this point in the history

  2. added wavelength parameter in feature detection functions

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ed47165 View commit details
    Browse the repository at this point in the history

  3. add check to ensure that wavelength input cannot be larger than the d… 

    …istance along both dimensions
    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    24b2951 View commit details
    Browse the repository at this point in the history

  4. add dxy to feature_detection_multithreshold_timestep because it is ne… 

    …eded if spectral filtering is desired
    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    ebcead6 View commit details
    Browse the repository at this point in the history

  5. formatting

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    66d363e View commit details
    Browse the repository at this point in the history

  6. add test for spectral_filtering

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    25a3f8d View commit details
    Browse the repository at this point in the history

  7. add better description of assert statements

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3479588 View commit details
    Browse the repository at this point in the history

  8. formatting

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3b10583 View commit details
    Browse the repository at this point in the history

  9. add comment in test_utils.py

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7139e8a View commit details
    Browse the repository at this point in the history

  10. add comment in test_utils.py

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    00bfcf7 View commit details
    Browse the repository at this point in the history

  11. added parametrizing fixture so that feature_detection_multithreshold_… 

    …timesteps is tested with and without spectral filtering option
    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    50e59ff View commit details
    Browse the repository at this point in the history

  12. formatting

    Juli committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a8c6be5 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. made all the necessary changes to have wavelengths in same unit as dx… 

    …y -> unit: meter
    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    761ecb7 View commit details
    Browse the repository at this point in the history

  2. added ValueError and warning to make sure wavelengths are given in ri… 

    …ght unit
    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    099552c View commit details
    Browse the repository at this point in the history

  3. modified testing for spectral filtering based on dat with wave signal

    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    a20dbed View commit details
    Browse the repository at this point in the history

  4. corrected import of fft function

    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0c56b55 View commit details
    Browse the repository at this point in the history

  5. formatting

    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    dbe9544 View commit details
    Browse the repository at this point in the history

  6. fixed issues for testing

    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    3347418 View commit details
    Browse the repository at this point in the history

  7. fixed wavelength unit also in test_feature_detection.py

    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2f0bead View commit details
    Browse the repository at this point in the history

  8. black formatting

    Juli committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f8ba18c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. specified black version in workflow

    Juli committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c15ad8d View commit details
    Browse the repository at this point in the history

  2. specify to use first stable version 22.6.0 of black in CONTRIBUTING.md

    Juli committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    02361d8 View commit details
    Browse the repository at this point in the history

  3. asking users to use at least first stable version of black in CONTRIB… 

    …UTING.md
    Juli committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    455abed View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. solve merge conflict

    Juli committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    1e65788 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'JuliaKukulies-spectral_filtering' into spectral_filtering 

    solcing merge conflicts
    Juli committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    c137d26 View commit details
    Browse the repository at this point in the history

  3. black formatting

    Juli committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    7a27401 View commit details
    Browse the repository at this point in the history