Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_requires='>=3.5' to setup.py #206

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

vphilippon
Copy link
Contributor

See #205

This strictly enforces the requirements for Python >=3.5.

After the merge+release, still needs a yank of the 0.17.0 release to make the Python2.7 ecosystem "safe" again :) .

@ChristineTChen
Copy link

@tobgu can you take a look at this? This is urgent as it affects many people/pipelines, thank you 🤞

@andrewegel
Copy link

+1 on yanking and re-issuing a 0.17.0 release.

@tobgu
Copy link
Owner

tobgu commented Sep 9, 2020

Thanks!

@wasilukm
Copy link

wasilukm commented Sep 9, 2020

Please note that this still may not prevent pip from installing incompatible version. In my case pip is trying to install 0.17.1 and quits with following error:
ERROR: Package 'pyrsistent' requires a different Python: 2.7.17 not in '>=3.5'

@AlanRosenthal
Copy link

I'm seeing the error when installing packages with conda

@vphilippon vphilippon deleted the python_requires branch November 13, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants