Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vue3-vite as supported builder #69

Merged

Conversation

floroz
Copy link
Contributor

@floroz floroz commented Aug 15, 2023

Expand types to support modern vue3-vite

@tobiasdiez tobiasdiez changed the title feat!: replace builder-vite with vue3-vite as default builder feat: replace builder-vite with vue3-vite as default builder Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #69 (050d826) into main (498c646) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           3        3           
  Lines         337      337           
  Branches       56       56           
=======================================
  Hits          315      315           
  Misses         22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tobiasdiez tobiasdiez changed the title feat: replace builder-vite with vue3-vite as default builder docs: replace builder-vite with vue3-vite as supported builder Sep 3, 2023
@tobiasdiez tobiasdiez changed the title docs: replace builder-vite with vue3-vite as supported builder docs: add vue3-vite as supported builder Sep 3, 2023
@tobiasdiez
Copy link
Owner

It's only a type import, so the package strictly speaking doesn't depend on either builder. The point is more that only vite is supported as of now but not webpack. I've added the old vite builder. Do you think my changes are okay?

@floroz floroz force-pushed the deps/replace-deprecated-viteconfig-type branch from 6d9ad37 to 050d826 Compare September 4, 2023 06:52
@floroz
Copy link
Contributor Author

floroz commented Sep 4, 2023

It's only a type import, so the package strictly speaking doesn't depend on either builder. The point is more that only vite is supported as of now but not webpack. I've added the old vite builder. Do you think my changes are okay?

Hey @tobiasdiez, thanks for the explanation. Yes, the changes look good.

So, based on what you are saying, it won't be a breaking change since we're not replacing one builder (builder-vite) for another, but updating support for types of the most recent builder (vue3-vite).

I've updated the commits to reflect that (and remove breaking change annotation).

@floroz floroz changed the title docs: add vue3-vite as supported builder feat: add vue3-vite as supported builder Sep 4, 2023
@tobiasdiez
Copy link
Owner

Okay perfect, then let's get this in immediately.

@tobiasdiez tobiasdiez merged commit ebadd98 into tobiasdiez:main Sep 4, 2023
9 checks passed
@floroz floroz deleted the deps/replace-deprecated-viteconfig-type branch September 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants