-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vue3-vite as supported builder #69
feat: add vue3-vite as supported builder #69
Conversation
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 3 3
Lines 337 337
Branches 56 56
=======================================
Hits 315 315
Misses 22 22 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It's only a type import, so the package strictly speaking doesn't depend on either builder. The point is more that only vite is supported as of now but not webpack. I've added the old vite builder. Do you think my changes are okay? |
6d9ad37
to
050d826
Compare
Hey @tobiasdiez, thanks for the explanation. Yes, the changes look good. So, based on what you are saying, it won't be a breaking change since we're not replacing one builder (builder-vite) for another, but updating support for types of the most recent builder (vue3-vite). I've updated the commits to reflect that (and remove breaking change annotation). |
Okay perfect, then let's get this in immediately. |
Expand types to support modern
vue3-vite