-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Status Indicators to Hajimari Apps #45
Conversation
Thanks for reworking this on the new branch! out of town till Wednesday so I'll give it a full look then but looking great so far 👍 |
No Problem! I finished up the basic pieces. Let me know if I should add any automated tests. I know the structure is evolving so it makes more sense for me to add those to parts on request so I don't spend time on those unnecessarily. After some experimenting I decided to use the accent color to indicate live replicas and tune to currentcolor for unavailable replicas. It should be pretty straighforward to adjust these as it's just a linear gradient with hard stops. |
Overview
CURRENTLY INCOMPLETEAddresses #20 to add Status Indicators to Hajimari Apps
Previous PR #35 is the initial attempt to do so.
Example screenshot:
Notable Changes
Remaining To-dos before PR will exit "Draft" status
Finish Indicator styling to reflect App Status.Automated TestsI can offer to do it but I feel like the structure is still being changed so I'll defer to the codeowner to decide if I should add theseAdjustments to dev setup?Will do in separate PR.To finish PR