Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status Indicators to Hajimari Apps #45

Merged
merged 19 commits into from
Sep 8, 2022
Merged

Conversation

h3mmy
Copy link
Contributor

@h3mmy h3mmy commented Sep 4, 2022

Overview

CURRENTLY INCOMPLETE

Addresses #20 to add Status Indicators to Hajimari Apps

Previous PR #35 is the initial attempt to do so.

Example screenshot:
hajimari_svelte_replica_status_example

Notable Changes

  • Move from v1beta1.Ingress to v1.Ingress. No adjustments required. Effectively drop-in.
  • Uses DiscoveryV1 and EndpointSlices to collect replica statuses instead of the AppsV1 Api as done in Add status indicators to hajimari apps #35. This means we don't have to distinguish between Deployments/DaemonSets/StatefulSets/etc.
  • EPSlices are filtered to limit service statuses to those specified in the Ingress.
  • Uses Svelte instead of the previous front-end implementation. This makes adjustments consistent with the v0.3.0 milestone.
  • Adds a ReplicaInfo field to the models.App object.
  • Changes models.AppGroup to use Name instead of Group for label. It makes it less ambiguous when figuring out what's what in the front-end.

Remaining To-dos before PR will exit "Draft" status

  • Finish Indicator styling to reflect App Status.
  • Automated Tests I can offer to do it but I feel like the structure is still being changed so I'll defer to the codeowner to decide if I should add these
  • Adjustments to dev setup? Will do in separate PR.

To finish PR

  • Any further changes requested by codeowner(s)

@toboshii
Copy link
Owner

toboshii commented Sep 4, 2022

Thanks for reworking this on the new branch! out of town till Wednesday so I'll give it a full look then but looking great so far 👍

@h3mmy h3mmy marked this pull request as ready for review September 4, 2022 17:20
@h3mmy
Copy link
Contributor Author

h3mmy commented Sep 4, 2022

Thanks for reworking this on the new branch! out of town till Wednesday so I'll give it a full look then but looking great so far 👍

No Problem! I finished up the basic pieces. Let me know if I should add any automated tests. I know the structure is evolving so it makes more sense for me to add those to parts on request so I don't spend time on those unnecessarily.

After some experimenting I decided to use the accent color to indicate live replicas and tune to currentcolor for unavailable replicas. It should be pretty straighforward to adjust these as it's just a linear gradient with hard stops.

@toboshii toboshii merged commit 6aa2895 into toboshii:svelte Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants