Add the ability to replace the URL text below the application name #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ullbergm
changed the title
|
Hi @ullbergm 👋, thanks for your contribution! Unfortunately you've happened upon a bad time to add this as we're working on the next release over on #44 and some of the parts you've modified are severely different. If you would like to rebase and update your changes on the svelte branch I'd love to include this for the next release. |
|
Sure thing, I'll take a look at doing that. |
|
Replaced by #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Gives the user an option to override the information line using an annotation. This should be a non-breaking change as it will default to displaying the URL like before.
Since this allows you to enter any html you want you can replace the text with a link to a status badge.
hajimari.io/info: "<img src='https://gatus.local/api/v1/endpoints/downloading_nzbget/uptimes/7d/badge.svg'>"