fix(frontend): add rel="external" to external links
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves the CSRF issue with some apps (most notably, QBitTorrent). TL;DR: some apps enforce that the `Referer` and `Target` headers must match, which isn't the case by default with `a` tags, `Referer` is the URL you were redirected from instead. This is generally fixed with `rel="noopener noreferrer"` (as implemented by @toboshii) but SvelteKit's router renders those options useless unless `rel="external"` is set as well.
|
Doh, when I tested I checked the html contents and saw the rel there after compiling, but I didn't think about the router grabbing and ignoring that... LGTM, 0.3.1 on it's way shortly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves the CSRF issue with some apps (most notably, QBitTorrent).
TL;DR: some apps enforce that the
RefererandTargetheaders must match,which isn't the case by default with
atags,Refereris the URL you wereredirected from instead.
This is generally fixed with
rel="noopener noreferrer"(as implemented by@toboshii) but SvelteKit's router renders those options useless unless
rel="external"is set as well. This effectively bypasses the client-siderouter for those links.
Resolves #48.