Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Country Whitelisting European Union but blocks German IPs #378

Open
euklidoid opened this issue Nov 5, 2024 · 6 comments
Open

[BUG] Country Whitelisting European Union but blocks German IPs #378

euklidoid opened this issue Nov 5, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@euklidoid
Copy link

euklidoid commented Nov 5, 2024

Describe the bug
Country Whitelisting European Union but blocks German IPs
Error: 404 You do not have permission to view this directory or page.
This might be caused by the region limit setting of this site.

To Reproduce
Steps to reproduce the behavior:

  1. Use macOS 15.01 tethered over iOS 18.1
  2. Establish LTE connection (o2 Germany)
  3. Use Browser [Vivaldi, Brave, Safari] to
  4. Access home network to zoraxy to be reproxied to any service (eg. Nextcloud)

Expected Behaivor
reproxied to Nextcloud login page

Work Around
add Germany to whitelist
(since I dont have a vpn I have no way to check if other EU Countries are effected too. We need to assume that up to 27 countries maybe blocked, even witelisted by selecting EU, So all 27 needs to be varified)

Screenshots

image

image

Host Environment (please complete the following information):

  • Arch: [Intel i5-9600T]
  • Device: [Lenovo Thinkcentre M920x]
  • OS: [Proxmox]
  • Version [8.27 ]
  • VM: [Debian GNU/Linux 12 (bookworm)]
  • Docker Compose (if you are running Zoraxy in docker): [v2.29.7]

Additional context
nope

@euklidoid euklidoid added the bug Something isn't working label Nov 5, 2024
@tobychui
Copy link
Owner

tobychui commented Nov 5, 2024

This sees to be a UI bug. In the actual geoip database, there isn't a tag for "EU"

https://github.com/tobychui/zoraxy/blob/main/src/mod/geodb/geoipv4.csv

And the EU tag should not be select-able from the drop down menu.

圖片

Will be removing this option in the next release.

@euklidoid
Copy link
Author

Please dont remove the EU tag, its so good and makes so much sense to see that EU as a region is awailble, I did the same exercise with Nextcloud, and there its so awkward to set the countries, with #Command plus left mouse click to mark each line, and if you miss click the whole marked list is gone.
If there is a easy way to keep a EU tag, that would be awesome.

thanks for coming back so fast

@euklidoid
Copy link
Author

and by the way, I realized that if you enable GeoBlocking, than I needed to white list my home network, otherwise I got refused. not sure if this is intended.

@tobychui
Copy link
Owner

tobychui commented Nov 6, 2024

@euklidoid Well if the EU tag has to be kept, then that means there will be a few more CPU cycles dedicated to resolve the EU country from a list of countries (as the current implementation of geoip uses trie tree, which can only resolve an ip address to a country code in that range). I will see what I can do.

I realized that if you enable GeoBlocking, than I needed to white list my home network, otherwise I got refused. not sure if this is intended.

GeoIP Access Rules do not have an options for LAN, so yes, you need to add your own home IP range in the whitelist or if you are using a loop-back setup, whitelist your own public IP address.

@euklidoid
Copy link
Author

about the EU thing, maybe its possible to use the EU tag like a macro, that basically does the manual check of those countries for the user, and then list them indivially or as EU as a whole. I know its a very minor thing, and Im the only one requesting, so whatever you can do is appreciated.

thanks for the great application

@DerLeole
Copy link

DerLeole commented Nov 7, 2024

@euklidoid idea sounds good. Instead of making the EU list something the server does, make it a UI feature, preferrably even outside of the main dropdown (maybe an extra preset dropdown). Select EU from the list of presets and the only thing done is that the clientside selects all the EU country from a list as if they were individually clicked.

tobychui added a commit that referenced this issue Nov 8, 2024
- Fixed #378
- Added wip dark theme
- Fixed in code typo
- Fixed int conversion bug in some DNS challenge supplier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants