Fix: generate single argument ArrayConcat without trailing comma fixes …

…#4259
tobymao · Oct 17, 2024 · 51f4d26 · 51f4d26
1 parent c43cae9
commit 51f4d26
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/sqlglot/generator.py b/sqlglot/generator.py
@@ -4253,7 +4253,7 @@ def arrayconcat_sql(self, expression: exp.ArrayConcat, name: str = "ARRAY_CONCAT
         else:
             rhs = self.expressions(expression)
 
-        return self.func(name, expression.this, rhs)
+        return self.func(name, expression.this, rhs or None)
 
     def converttimezone_sql(self, expression: exp.ConvertTimezone) -> str:
         if self.SUPPORTS_CONVERT_TIMEZONE:

diff --git a/tests/dialects/test_bigquery.py b/tests/dialects/test_bigquery.py
@@ -107,6 +107,7 @@ def test_bigquery(self):
         select_with_quoted_udf = self.validate_identity("SELECT `p.d.UdF`(data) FROM `p.d.t`")
         self.assertEqual(select_with_quoted_udf.selects[0].name, "p.d.UdF")
 
+        self.validate_identity("SELECT ARRAY_CONCAT([1])")
         self.validate_identity("SELECT * FROM READ_CSV('bla.csv')")
         self.validate_identity("CAST(x AS STRUCT<list ARRAY<INT64>>)")
         self.validate_identity("assert.true(1 = 1)")