Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): translate variance_pop to var_pop and variance to var_samp #2371

Merged
merged 3 commits into from
Oct 4, 2023
Merged

fix(postgres): translate variance_pop to var_pop and variance to var_samp #2371

merged 3 commits into from
Oct 4, 2023

Conversation

cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Oct 4, 2023

Fixes a bug in transalation of population variance and also translates sample variance into var_samp which is compatible with datafusion postgres.

@cpcloud cpcloud changed the title var pop samp fix(postgres): translate variance_pop to var_pop and variance to var_samp Oct 4, 2023
georgesittas
georgesittas approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgesittas georgesittas merged commit 6a65a09 into tobymao:main Oct 4, 2023
5 checks passed
@cpcloud cpcloud deleted the var-pop-samp branch October 4, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @georgesittas