Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(optimizer)!: Add type hints for optimizer rules eliminate & merge subqueries #4267

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix(optimizer)!: Add type hints for optimizer rules eliminate & merge subqueries #4267

merged 3 commits into from
Oct 21, 2024

Conversation

VaggelisD
Copy link
Collaborator

Follow up on #4266

georgesittas
georgesittas reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some polishing but LGTM otherwise. Let's mark this as breaking so that folks using these rules won't suddenly get cascading mypy issues.

sqlglot/optimizer/eliminate_subqueries.py Outdated Show resolved Hide resolved
sqlglot/optimizer/eliminate_subqueries.py Show resolved Hide resolved
sqlglot/optimizer/eliminate_subqueries.py Outdated Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Outdated Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Outdated Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Outdated Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Show resolved Hide resolved
@VaggelisD VaggelisD changed the title fix(optimizer): Add type hints for optimizer rules eliminate & merge subqueries fix(optimizer)!: Add type hints for optimizer rules eliminate & merge subqueries Oct 18, 2024
georgesittas
georgesittas reviewed Oct 21, 2024
View reviewed changes
sqlglot/optimizer/eliminate_subqueries.py Outdated Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Outdated Show resolved Hide resolved
@georgesittas georgesittas merged commit 222152e into main Oct 21, 2024
6 checks passed
@georgesittas georgesittas deleted the vaggelisd/annotate_rules branch October 21, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

@barakalon barakalon Awaiting requested review from barakalon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VaggelisD @georgesittas